Repository navigation
fix(deps): update module github.com/sourcehawk/go-crd-condition-metrics to v1.2.0 - #259
Open
renovate[bot] wants to merge 1 commit into
Open
renovate[bot] wants to merge 1 commit into
renovate[bot] wants to merge 1 commit into
Conversation
Contributor
Author
ℹ️ Artifact update noticeFile name: go.modIn order to perform the update(s) described in the table above, Renovate ran the
Details:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
v1.1.0→v1.2.0Release Notes
sourcehawk/go-crd-condition-metrics (github.com/sourcehawk/go-crd-condition-metrics)
v1.2.0Compare Source
Overview
This release adds Prometheus alert rules for the condition metric, a method that removes the metric of one condition type, and a corrected README example that no longer leaves stale metrics after a resource is deleted. It also updates the Prometheus client and the other dependencies. The module now needs Go 1.26 or later.
What's new
Alert rules for CRD conditions. Before, this repository had a dashboard for the condition metric but no alert rules, so each operator wrote its alerts from nothing.
make alerts METRIC_NAMESPACE=<your_operator>now generates aPrometheusRulewith three rules (#7):CustomResourceNotReady: theReadycondition isFalsefor 30 minutes.CustomResourceConditionUnknown: a condition isUnknownfor 30 minutes.CustomResourceConditionStuck:Readyhas not beenTruefor more than 6 hours since its last transition. A gap in the series does not reset this time.The rules are starting points with
severity: warningand no routing labels.NAMESPACE_LABELsets the label that holds the namespace of the resource (defaultexported_namespace). Thealerts/README.mdfile tells you what to tune.Remove the metric of one condition type. Before, when a controller removed a condition type from the status, its series stayed until the whole resource was removed.
RemoveConditionFor(kind, obj, conditionType)removes the series of that one condition type and keeps the others. Call it when you remove the condition from the status, for example withmeta.RemoveStatusCondition. (#10)Fixes
GetreturnsNotFound. If you copied the old example, move yourRemoveConditionsForcall to theNotFoundpath. (#10)Get, and again after a status update succeeds. (#10)What's changed
client_golangv1.25.0 andcommonv0.74.0 need Go 1.26, so thegodirective ingo.modchanges from 1.25 to 1.26.0. If your module is on Go 1.25, move to Go 1.26 before you upgrade. Go 1.25 no longer gets security fixes. (#8)client_golangv1.23.2 → v1.25.0,commonv0.67.5 → v0.74.0,testifyv1.11.1 → v1.12.1, andgo-prometheus-gaugevecsetv1.1.0 → v1.2.0, with their indirect dependencies. Your module gets these versions when it upgrades to this release. (#5, #8, #10)Changelog
Full Changelog: sourcehawk/go-crd-condition-metrics@v1.1.0...v1.2.0
Configuration
📅 Schedule: (UTC)
* * 1,15 * *)🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.